Fix editor mobile file open #2770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Sep 9, 2021
|
The point was to fix the bug (file modal on mobile). The file modal class turned out to be broken, so I removed it. One thing using it was a bunch of dead code for USDZ support I'd already removed from the UI for the reason you noted. So I decided to strip out the rest of the related state while I was there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2672
I'm not sure why it wasn't working on mobile, but simplifying it fixed it. I decided to take the opportunity to remove all the USDZ-related dead code as well, since I don't want to maintain it. The editor can focus on the auto-generation path.