Fix xr-environment #2847
Merged
Fix xr-environment #2847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a way to control the frequency of lighting updates? I know in SceneViewer controlling this helped to reduce pressure on the GPU. |
ghost
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed recently that though the
xr-environmentattribute is supposed to be opt-in for WebXR estimated lighting, it was in fact enabled all the time accidentally. This rectifies that and also takes care of properly disposing of it at session end.A handy way to test this is to edit the snippet in our editor and add the
xr-environmentattribute. Even though its not exposed in the UI, any MV attributes you add will be respected by both the local view and the mobile deployments, which makes it easy to test advanced features.