fixed NaN cameraOrbit #4041
Merged
fixed NaN cameraOrbit #4041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elalish
commented
Jan 10, 2023
| @@ -508,7 +512,7 @@ export class SmoothControls extends EventDispatcher { | |||
| } | |||
|
|
|||
| private pixelLengthToSphericalAngle(pixelLength: number): number { | |||
| return 2 * Math.PI * pixelLength / this.element.clientHeight; | |||
| return 2 * Math.PI * pixelLength / this.scene.height; | |||
There was a problem hiding this comment.
I have no idea why clientHeight was used here; scene.height is correct as this is the one that is assured to never be < 1.
samaneh-kazemi
approved these changes
Jan 10, 2023
elalish
added a commit
that referenced
this pull request
Jan 10, 2023
JL-Vidinoti
pushed a commit
to vidinoti/model-viewer
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two fixes here, one for the actual problem, and a second to act as a backstop against similar problems. Both were verified to independently fix the issue via the included test.
I also verified that no matter what nonsense you put into
camera-orbitorcameraOrbit, it will never produce NaN, it instead falls back to the default initial values.