Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated to three.js r151 #4186

Merged
merged 3 commits into from
Mar 31, 2023
Merged

updated to three.js r151 #4186

merged 3 commits into from
Mar 31, 2023

Conversation

elalish
Copy link
Collaborator

@elalish elalish commented Mar 31, 2023

Lots of rendering improvements this time, most notably that multiple UV channels and texture transforms are fully and properly supported now, which is a huge win especially for models using a tiled texture swatch as well as a non-tiled AO map, e.g. Sheen Chair:
image
Further proof:
image
Also significant improvement of back-side reflections of transmissive materials:
image
I need to dig a little deeper into what's changed with punctual lights:
image
And also with the Glam sofa:
image

@elalish elalish self-assigned this Mar 31, 2023
@elalish
Copy link
Collaborator Author

elalish commented Mar 31, 2023

@mrdoob This is looking great overall! I can't quite figure out why the last two renders changed. Not saying it's a regression, but I'd like to understand for sake of glTF compliance and other renderers. Any thoughts?

@elalish
Copy link
Collaborator Author

elalish commented Mar 31, 2023

Yeah, @mrdoob there's definitely something going on here; these used to look a lot more similar: https://modelviewer.dev/fidelity/#khronos-LightsPunctualLamp

This one's also looking not great - it was too dark before, and now it's much too light: https://modelviewer.dev/fidelity/#khronos-GlamVelvetSofa

elalish added a commit that referenced this pull request Mar 31, 2023
@elalish
Copy link
Collaborator Author

elalish commented Mar 31, 2023

@mrdoob Okay, my best guess is whatever is causing that change to the LightsPunctualLamp also blew out our default lighting, so that's become a blocker.

elalish added a commit that referenced this pull request Mar 31, 2023
@elalish elalish mentioned this pull request Mar 31, 2023
@elalish
Copy link
Collaborator Author

elalish commented Apr 1, 2023

Okay, nevermind, I realized I just got hit by mrdoob/three.js#25479. The one-liner fixed it and it only took an hour to figure it out, so not bad overall. And apparently GlamVelvetSofa has a punctual light (!?!).

@ocrnalic
Copy link

ocrnalic commented May 6, 2023

Hi, this works great on model viewer and android, but when autogenerated usdz file is opened on Iphone second UV map doesn't work. Is there some naming rule for UV maps, or it just isnt supported for USDZ autogeneration?

@mrdoob
Copy link
Collaborator

mrdoob commented May 6, 2023

The current state of USDZ is a bit of a mess:
https://twitter.com/mrdoob/status/1654494500230778887

@mrdoob
Copy link
Collaborator

mrdoob commented May 6, 2023

In theory this should work but I don't think it does.
mrdoob/three.js#25996

@ocrnalic
Copy link

ocrnalic commented May 7, 2023

The current state of USDZ is a bit of a mess:
https://twitter.com/mrdoob/status/1654494500230778887

In gerneral autogeneration works perfectly except for models with animations and multiple uv maps

@ocrnalic
Copy link

@elalish do you maybe have some info about multiple UV sets and USDZ autogeneration. Does this work or still isnt supported? I have tried with only AO on the second set and I cant make it work… thanks!

@elalish
Copy link
Collaborator Author

elalish commented May 10, 2023

I'm guessing you're looking for this, which we can pull down at the end of the month when it's released.

@ocrnalic
Copy link

@elalish @mrdoob thank you for help, I'm not a developer, so maybe I don't understand everything the best...
But I have made some tests..
I have created a very simple scene wher AO is baked on second UV map
image
It works correct in model viewer but after autogeneration second uv-map is not displayed correctly
image

But when I convert glb file using this online convertor (https://arize.io/tools/usdz-converter/) to usdz
On Iphone it works correctly! It also works right on https://www.usdz-viewer.net/
image

Here are the files:
cube.zip

So somehow this online converter is converting in the right way comparing to autogeneration.

So if I understand correctly, this will be fixed by the end of the month as elalish wrote (mrdoob/three.js#26023)?
or i got it wrong? :)

Thanks!

@elalish
Copy link
Collaborator Author

elalish commented May 11, 2023

That's correct - please help us test and verify once that lands.

@ocrnalic
Copy link

Great!! off course I will test in detail when it will be released

JL-Vidinoti pushed a commit to vidinoti/model-viewer that referenced this pull request Apr 22, 2024
* updated to three.js r151

* r151.2

* updated goldens
JL-Vidinoti pushed a commit to vidinoti/model-viewer that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants