Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove doubled period from start of alt text. #4237

Merged
merged 1 commit into from
Apr 21, 2023
Merged

fix: Remove doubled period from start of alt text. #4237

merged 1 commit into from
Apr 21, 2023

Conversation

ashleahhill
Copy link
Contributor

Removes ending period from custom alt text if it exists.

Reference Issue

Fixes #4236

elalish
elalish approved these changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elalish elalish merged commit 6583b25 into google:master Apr 21, 2023
3 checks passed
JL-Vidinoti pushed a commit to vidinoti/model-viewer that referenced this pull request Apr 22, 2024
@ashleahhill
fix: Remove doubled period from start of alt text. (google#4237)
a8ffc8b 
Closes google#4236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elalish elalish elalish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alt text can add double periods
2 participants
@ashleahhill @elalish