Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright CI #4268

Merged
merged 34 commits into from May 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions .eslintignore
Expand Up @@ -4,8 +4,6 @@ packages/*/dist
packages/**/*.d.ts
packages/*/src/*-css.ts

packages/*/karma.*.js

packages/model-viewer/**/*
packages/model-viewer-effects/**/*
packages/modelviewer.dev/**/*
Expand Down
31 changes: 0 additions & 31 deletions .github/workflows/unit-tests-third-party.yml

This file was deleted.

26 changes: 4 additions & 22 deletions .github/workflows/unit-tests.yml
Expand Up @@ -5,26 +5,10 @@ on: [push]
jobs:
full_test_run:

env:
USE_BROWSER_STACK: true

runs-on: ubuntu-latest
timeout-minutes: 60

steps:
- name: 'BrowserStack Env Setup' # Invokes the setup-env action
uses: browserstack/github-actions/setup-env@master
with:
username: ${{ secrets.BROWSER_STACK_USERNAME }}
access-key: ${{ secrets.BROWSER_STACK_ACCESS_KEY }}

- name: 'BrowserStack Local Tunnel Setup' # Invokes the setup-local action
uses: browserstack/github-actions/setup-local@master
with:
local-testing: start
local-identifier: test
local-logging-level: setup-logs

- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
Expand All @@ -33,6 +17,9 @@ jobs:
- name: NPM install
run: npm ci

- name: Install playwright browsers
run: npx playwright install --with-deps

# - name: Lint TypeScript sources
# run: npm run lint

Expand All @@ -43,9 +30,4 @@ jobs:
run: npm run build

- name: Unit tests
run: npm run test:ci

- name: 'BrowserStackLocal Stop' # Terminating the BrowserStackLocal tunnel connection
uses: browserstack/github-actions/setup-local@master
with:
local-testing: stop
run: npm run test:ci
120 changes: 60 additions & 60 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.