Add fix for Wrapping exposed #4499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elalish
requested changes
Oct 5, 2023
| @@ -1,4 +1,4 @@ | |||
| import {TextureFilter, Wrapping} from 'three'; | |||
| import {TextureFilter} from 'three'; | |||
There was a problem hiding this comment.
We need to remove this too.
There was a problem hiding this comment.
Leaving this for a follow up PR.
elalish
reviewed
Oct 5, 2023
| @@ -499,6 +499,12 @@ <h2 class="demo-title">Transform textures</h2> | |||
| <input type="range" min="0.5" max="1.5" value="1" step="0.01" id="scaleSlider"> | |||
| <p>Offset</p> | |||
| <input type="range" min="0" max="1" value="0" step="0.01" id="offsetSlider"> | |||
| <p>WrapMode</p> | |||
| <select id="wrapMode"> | |||
| <option value="10497">Repeat</option> | |||
There was a problem hiding this comment.
Can you switch this to Wrap.Repeat etc? I want to ensure our enum is properly exported.
There was a problem hiding this comment.
If it doesn't work, we probably have to re-export it from model-viewer.ts.
There was a problem hiding this comment.
We realized at the office that making this work might take a bit more time of work, leaving it for another index.html cleanup :/
JL-Vidinoti
pushed a commit
to vidinoti/model-viewer
that referenced
this pull request
Apr 22, 2024
* Add fix for Wrapping exposed * Add example * Fix sampler updating * Added WrapMode comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #4494