Added example to toggle between mesh variants #4528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elalish
requested changes
Oct 24, 2023
There was a problem hiding this comment.
Nice work, the functionality is great! And thanks for including the Glitch link - very helpful for review.
Since this is a public example, code clarity and simplicity are of the utmost importance - I've put in several pointers, but please look through for any ways you can make it simpler and easier to read.
…ing options declerative
elalish
requested changes
Oct 27, 2023
There was a problem hiding this comment.
I just made exactly this mistake - you need to also add this file to ci-before-deploy.sh or else the public example page won't be able to find it.
There was a problem hiding this comment.
hmm wouldn't this cover it?
shared-assets/models/. \
There was a problem hiding this comment.
Oh shoot, you're right! Thanks.
elalish
approved these changes
Oct 27, 2023
JL-Vidinoti
pushed a commit
to vidinoti/model-viewer
that referenced
this pull request
Apr 22, 2024
* Added example to toggle between mesh variants * Fixed the alt * Addressed some of the comments including changing updateAlpha and making options declerative * simplify code and address all comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
link to glitch: