Enable transparencyAsCoverage in Babylon Viewer

[bghgary]

Reference Issue

See KhronosGroup/glTF-Sample-Assets#34 (comment)

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[elalish]

Thank you! Is it working? You may want to update the babylon.js version while you're at it; it's probably quite out of date.

[bghgary]

No idea. I am not having luck getting it to run locally. I was hoping the CI can run it instead.

[bghgary]

@elalish I am unable to get the cla/google to pass since I only use the users.noreply.github.com email in my commits which doesn't work apparently. Maybe you can take it further?

EDIT: Never mind. It works. I just need to rescan.

[bghgary]

I don't know what full_test_run is and why it's waiting.

You may want to update the babylon.js version while you're at it; it's probably quite out of date.

Maybe as a separate PR to limit the changes.

[elalish]

Oh, don't worry about full_test_run - you're not changing anything in that code anyway. I need to update our CI for contributors. And it looks like @bhouston updated Babylon in #4535, so we should be good.

[elalish]

Thanks!

[elalish]

So, our CI does't actually run any renderers besides <model-viewer>. Let's let a few more of @bhouston's PRs land and that should make it easier for you to update goldens.

[bghgary]

that should make it easier for you to update goldens.

Hmm, I don't see any information on this, so I have no idea what you are talking about.

[elalish]

#4542

[bghgary]

Ok, just tell me what I need to do. I can't even get the npm run test to work locally.

[elalish]

Okay, if your dev environment isn't working then I'll assume you know how to write Babylon code like this blindly. I'll go ahead and merge it. If @bhouston has any trouble making babylon goldens, he can ping you here or there.

[bghgary]

I would definitely prefer for it to work, but let me know if something goes wrong with this change.