Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit file extensions to relative imports of model-viewer and model-viewer-effects #4707

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

chamby
Copy link
Contributor

@chamby chamby commented Mar 11, 2024

Reference Issue

Fixes: #4688

Copy link
Collaborator

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Not sure why we had our imports half and half - consistency is good!

@elalish elalish merged commit 17ebe09 into google:master Mar 11, 2024
3 checks passed
@chamby chamby deleted the explicit-import-extensions branch March 12, 2024 16:00
chamby added a commit to chamby/model-viewer that referenced this pull request Mar 12, 2024
elalish pushed a commit that referenced this pull request Mar 13, 2024
JL-Vidinoti pushed a commit to vidinoti/model-viewer that referenced this pull request Apr 22, 2024
JL-Vidinoti pushed a commit to vidinoti/model-viewer that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module not found: Error: Can't resolve './styles/evaluators', and many more
2 participants