Introduce result type #24

yrezgui · 2021-06-21T14:52:32Z

Upgrade ModernStorage to 1.5.10 Rename MediaStoreClient.kt to MediaStoreRepository.kt Add permission handlers to MediaStoreRepository Rename MediaResource to FileResource Add @parcelize to FileResource Expand media support to audio files Simplify API naming Add file scanning feature Update sample app

…l methods in MediaStoreRepository

manuelvicnt · 2021-06-22T09:33:53Z

sample/src/main/java/com/google/modernstorage/sample/mediastore/MediaStoreViewModel.kt


-            withContext(Dispatchers.IO) {
-                val response = httpClient.newCall(request).execute()
+        return withContext(Dispatchers.IO) {


Suggested change

return withContext(Dispatchers.IO) {

return withContext(ioDispatcher) {

The IO dispatcher should be injected into the ViewModel to make testing easier

sample/src/main/java/com/google/modernstorage/sample/mediastore/MediaStoreViewModel.kt

sample/src/main/java/com/google/modernstorage/sample/mediastore/MediaStoreFragment.kt

sample/src/main/java/com/google/modernstorage/sample/mediastore/MediaStoreViewModel.kt

Remove companion object Simplify scanning logic Update api metadata

…e/MediaStoreViewModel.kt Co-authored-by: Lukas Valkovic <lukasvalkovic@users.noreply.github.com>

google-cla · 2021-06-22T21:26:34Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-23T08:46:51Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Format code

google-cla · 2021-06-23T10:15:07Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

lukasvalkovic · 2021-06-23T10:35:08Z

@googlebot I fixed it.

Format code Standardize argument names Generate api metadata

Compiler bug with Result type when using suspend functions

Update README.md

Set FileType.NONE as FileResource type property (until I can figure out how to get media type value from MediaStore)

mediastore/src/main/java/com/google/modernstorage/mediastore/MediaStoreRepository.kt

mediastore/src/main/java/com/google/modernstorage/mediastore/Exceptions.kt

mediastore/src/main/java/com/google/modernstorage/mediastore/MediaStoreRepository.kt

…olumn property Extend UnsupportedMediaUriException from IllegalArgumentException instead of UnsupportedOperationException

Simplify FileResource.getEnum method logic

yrezgui added 9 commits June 21, 2021 15:46

Centralize exceptions in a file

bd3ffbc

Upgrade ModernStorage to 1.5.10

26d7497

Merge branch 'main' into introduce-result-type

8121943

Upgrade fragment-ktx in the sample to 1.3.5

e55a68d

Remove duplicate plugins declaration

d29661a

Generate metalava changes

96e4044

Modify coroutineScope to coroutineContext as optional parameter to al…

5a455a2

…l methods in MediaStoreRepository

manuelvicnt reviewed Jun 22, 2021

View reviewed changes

sample/src/main/java/com/google/modernstorage/sample/mediastore/MediaStoreViewModel.kt Outdated Show resolved Hide resolved

manuelvicnt reviewed Jun 22, 2021

View reviewed changes

sample/src/main/java/com/google/modernstorage/sample/mediastore/MediaStoreFragment.kt Outdated Show resolved Hide resolved

yrezgui added this to To Do in Roadmap Jun 22, 2021

yrezgui moved this from To Do to In Progress in Roadmap Jun 22, 2021

lukasvalkovic reviewed Jun 22, 2021

View reviewed changes

sample/src/main/java/com/google/modernstorage/sample/mediastore/MediaStoreViewModel.kt Outdated Show resolved Hide resolved

yrezgui and others added 2 commits June 22, 2021 22:18

Update KDOC of MediaStoreRepository.kt

2da9276

Remove companion object Simplify scanning logic Update api metadata

Update sample/src/main/java/com/google/modernstorage/sample/mediastor…

49c46a5

…e/MediaStoreViewModel.kt Co-authored-by: Lukas Valkovic <lukasvalkovic@users.noreply.github.com>

Add README and mediastore guides

7899a14

Add .editorconfig

51a8546

Format code

yrezgui added 7 commits June 23, 2021 16:15

Update MediaStoreRepository methods to only use optional context

78a907a

Upgrade to Kotlin 1.5.20

3cee0d5

Add getFile method to FileResource

23a07bf

Format code Standardize argument names Generate api metadata

Improve mediastore sample architecture

96edf64

Revert Kotlin version to 1.4.32

4a71c64

Compiler bug with Result type when using suspend functions

Use exception constructors instead of using utility functions

ac0e3e9

Update README.md

Add id property to FileResource

0901d23

Set FileType.NONE as FileResource type property (until I can figure out how to get media type value from MediaStore)

nic0lette approved these changes Jun 30, 2021

View reviewed changes

yrezgui added 4 commits June 30, 2021 11:41

Add FileResource type property support

ab05938

Use MediaColumns.DISPLAY_NAME instead of relying on each collection c…

5aef182

…olumn property Extend UnsupportedMediaUriException from IllegalArgumentException instead of UnsupportedOperationException

Fix media resource uri check

3c36614

Simplify FileResource.getEnum method logic

Add doc publishing CI task

d9a398b

yrezgui merged commit f2e5b62 into main Jun 30, 2021

Roadmap automation moved this from In Progress to Done Jun 30, 2021

yrezgui deleted the introduce-result-type branch June 30, 2021 14:04

This was referenced Jun 30, 2021

Add ID Column #6

Closed

Add Documentation. #2

Closed

Setup Mkdocs #3

Closed

Jetpack Compose #28

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce result type #24

Introduce result type #24

yrezgui commented Jun 21, 2021 •

edited

manuelvicnt Jun 22, 2021

google-cla bot commented Jun 22, 2021

google-cla bot commented Jun 23, 2021

google-cla bot commented Jun 23, 2021

lukasvalkovic commented Jun 23, 2021

	return withContext(Dispatchers.IO) {
	return withContext(ioDispatcher) {

Introduce result type #24

Introduce result type #24

Conversation

yrezgui commented Jun 21, 2021 • edited

manuelvicnt Jun 22, 2021

Choose a reason for hiding this comment

google-cla bot commented Jun 22, 2021

google-cla bot commented Jun 23, 2021

google-cla bot commented Jun 23, 2021

lukasvalkovic commented Jun 23, 2021

yrezgui commented Jun 21, 2021 •

edited