Skip to content
This repository has been archived by the owner on Feb 22, 2024. It is now read-only.

Add basic github action to test build #9

Merged
merged 6 commits into from Jun 9, 2021
Merged

Add basic github action to test build #9

merged 6 commits into from Jun 9, 2021

Conversation

utzcoz
Copy link
Contributor

@utzcoz utzcoz commented May 11, 2021

It adds basic GitHub Actions to test build only now.

@utzcoz
Copy link
Contributor Author

utzcoz commented May 11, 2021

Hi @yrezgui, could you help to review this PR? Thanks.

@utzcoz
Copy link
Contributor Author

utzcoz commented May 11, 2021

.github/workflows/build.yml Outdated Show resolved Hide resolved
@utzcoz
Copy link
Contributor Author

utzcoz commented May 30, 2021

Hi @yrezgui , is there any update for it ? I rebased it to current main branch.

Signed-off-by: utzcoz <utzcoz@outlook.com>
Signed-off-by: utzcoz <utzcoz@outlook.com>
Signed-off-by: utzcoz <utzcoz@outlook.com>
@utzcoz
Copy link
Contributor Author

utzcoz commented Jun 9, 2021

New running result with new spotless checking commit is here: https://github.com/utzcoz/modernstorage/runs/2785008975 .

Copy link
Collaborator

@yrezgui yrezgui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some suggestions. Thanks @utzcoz !

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
Signed-off-by: utzcoz <utzcoz@outlook.com>
@google-cla
Copy link

google-cla bot commented Jun 9, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

Signed-off-by: utzcoz <utzcoz@outlook.com>
@utzcoz
Copy link
Contributor Author

utzcoz commented Jun 9, 2021

New running result is here: https://github.com/utzcoz/modernstorage/runs/2785626392.

.github/workflows/build.yml Outdated Show resolved Hide resolved
@yrezgui yrezgui merged commit e387f00 into google:main Jun 9, 2021
@utzcoz utzcoz deleted the add-basic-github-actions branch June 10, 2021 00:12
@utzcoz
Copy link
Contributor Author

utzcoz commented Jun 10, 2021

Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants