Skip to content
This repository has been archived by the owner on May 29, 2023. It is now read-only.

Commit

Permalink
Rename rootsChanged to rootSetChan
Browse files Browse the repository at this point in the history
No longer implies that the RootSetID changes between messages.
  • Loading branch information
Rob Percival committed Jan 22, 2020
1 parent c254768 commit 080951d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions rootsanalyzer/rootsanalyzer.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ type incidentTemplateArgs struct {

// Run starts a Roots Analyzer, which watches a CT log's root certificates and creates incident reports for changes to them.
func Run(ctx context.Context, st storage.RootsReader, rep incident.Reporter, l *ctlog.Log) {
rootsChanged, err := st.WatchRoots(ctx, l)
rootSetChan, err := st.WatchRoots(ctx, l)
if err != nil {
glog.Errorf("%s: %s: storage.RootsReader.WatchRoots() = %q", l.URL, logStr, err)
return
Expand All @@ -65,7 +65,7 @@ func Run(ctx context.Context, st storage.RootsReader, rep incident.Reporter, l *
select {
case <-ctx.Done():
return
case rootSetID := <-rootsChanged:
case rootSetID := <-rootSetChan:
if lastRootSetID != "" && lastRootSetID != rootSetID {
// TODO(RJPercival): If the root set is flapping back to what it recently was, suppress sending an incident report
// since it could just be the result of skew between log frontends. However, if it doesn't flap back to the new
Expand Down

0 comments on commit 080951d

Please sign in to comment.