Remove dependency on iconv #252
Assignees
Comments
yukawa
pushed a commit
that referenced
this issue
Oct 25, 2015
The encoding related functions are a part of Util (declared in util.h)
but their implementations are in iconv.cc. This CL cleans up this
relation by introducing encoding_util.{h,cc}.
BUG=#252
TEST=unittest
REF_BUG=19010851
REF_CL=84839234
yukawa
pushed a commit
that referenced
this issue
Oct 25, 2015
BUG=#252 TEST=unittest REF_BUG=19010851 REF_CL=84862327
yukawa
added a commit
that referenced
this issue
Oct 25, 2015
client_scenario_test and client_stress_test are no longer intensively used nowadays. Probably it makes sense to remove less important options in favor of maintainability. With this removal, we can remove EncodingUtil::UTF8ToSJIS completely. BUG=#252 TEST=unittest REF_BUG=19010851,18999934 REF_CL=84930641
yukawa
added a commit
that referenced
this issue
Nov 9, 2015
This is a series of CLs to drop dependency on iconv (#252). UTF8ToSJIS is used only in Windows build. We can move it from src/base/encoding_util.cc to src/win32/base/string_util.cc to in favor of simplicity. This is just a refactoring. No behavior change is intended. BUG=#252 TEST=unittest REF_BUG=19010851 REF_CL=87124492
yukawa
pushed a commit
that referenced
this issue
Nov 9, 2015
This is a series of CLs to drop dependency on iconv (#252). MS-IME user dictionary importer is only used from src/gui/. Moving it to src/gui/base/ makes build dependency simpler and possibly improves build time depending on build configurations and build targets. BUG=#252 TEST=unittest REF_BUG=19010851 REF_CL=87220744
yukawa
pushed a commit
that referenced
this issue
Nov 14, 2015
encoding_util is used only by mozc_tool. Moving it to src/gui/base consolidates build dependencies and improves code portability. This is just a refactoring. No behavior change is intended. BUG=#252 TEST=unittest REF_BUG=19010851 REF_CL=87592180
yukawa
added a commit
that referenced
this issue
Jul 24, 2016
This is a follow up CL to 766685b, which got rid of the dependency on iconv. Even though we do not have any plan to use mozc::EncodingUtil in Android build, in theory this class is compatible with Android. Hence having OS_ANDROID does not make sense anymore. BUG=#27,#252 TEST= REF_BUG= REF_CL=107354157
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As of ce466e5, src/base/iconv.cc implements following methods.
mozc::Util::UTF8ToEUCmozc::Util::EUCToUTF8mozc::Util::UTF8ToSJISmozc::Util::SJISToUTF8mozc::Util::ToUTF8However, those methods are not used in production in practice except for
Util::UTF8ToSJIS. Apparently Mozc depends oniconvunnecessarily.The text was updated successfully, but these errors were encountered: