Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt candidate window: Candidate window blinks by a key type #548

Closed
ftake opened this issue Feb 12, 2022 · 5 comments
Closed

Qt candidate window: Candidate window blinks by a key type #548

ftake opened this issue Feb 12, 2022 · 5 comments

Comments

@ftake
Copy link
Contributor

ftake commented Feb 12, 2022

The current implementation seems to hide/show its candidate window every key type. Especially when window show/hide animation is enabled by a desktop environment, this hide/show is slow, and the window blinks.

I'm not sure there is suitable Qt flags to disable this type of animation.

@hiroyuki-komatsu
Copy link
Collaborator

Hi, thank you for the report.

Would you share steps how we can reproduce this problem?
I'm wondering how you enabled the window show/hide animation.

@ftake
Copy link
Contributor Author

ftake commented Feb 13, 2022

Under KDE Plasma 5, the animation is enabled by default if graphic acceleration is available. You can configure it by using KDE System Setting > Workspace Behavior

  • Desktop Effects
    Screenshot_20220213_213707

  • General Behavior (for animation speed)
    Screenshot_20220213_213326

It seems that window animation is not applied to the candidate window under GNOME environment (which also have window show/hide animation). I will test with other desktop environments.

@hiroyuki-komatsu
Copy link
Collaborator

Thank you for the instruction.
I was able to reproduce this issue on my KDE Plasma.

I'm investigating the issue.

hiroyuki-komatsu added a commit that referenced this issue Feb 22, 2022
* Whole refactoring of Qt base candidate window
  + #520
  + #547
  + #548
* Modified the ranking logic of number rewriter
* Code cleanup

PiperOrigin-RevId: 430131041
@hiroyuki-komatsu
Copy link
Collaborator

I performed the whole refactoring.

7d0959e fixed this issue on my environment.

Feel free to reopen this issue, if the problem is not fixed yet on your environment.
Thanks for your report.

@ftake
Copy link
Contributor Author

ftake commented Feb 23, 2022

Thank you. I confirmed this issue is resolved.
Now resize animation is applied but it will not be a problem if animation speed is normal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants