Consider uploading installers as artifacts from GitHub build actions #730
Comments
hiroyuki-komatsu
pushed a commit
that referenced
this issue
Apr 27, 2023
Before uploading build artifacts from GitHub Actions (#730), let's remind people that Mozc is not an officially supported Google product once again. PiperOrigin-RevId: 526668089
hiroyuki-komatsu
pushed a commit
that referenced
this issue
Apr 27, 2023
This is a follow up for #730. Now that GitHub Actions can upload installers for macOS and Windows, it's indeed a valid option for developers to build Mozc installers with their own commits. Let's remind such a way in the build instructions. PiperOrigin-RevId: 526715039
hiroyuki-komatsu
pushed a commit
that referenced
this issue
Sep 1, 2023
This is a follow up to my commit [1], which enabled GitHub Actions to upload build artifacts for Windows, macOS, and Linux but not for Android. This commit is to also support Android. One interesting requirement for Android is that developers usually need to build *.so for the following 4 architectures. - armeabi-v7a - arm64-v8a - x86 - x86_64 With this commit, our GitHub Actions rule actually starts building 'libmozcjni.so' for the above 4 architectures, then archives them into a single zip file and upload it as the final artifact. [1]: bb50663 PiperOrigin-RevId: 561867498
coooooooozy
pushed a commit
to coooooooozy/mozc
that referenced
this issue
Nov 26, 2023
This is a follow up to my commit [1], which enabled GitHub Actions to upload build artifacts for Windows, macOS, and Linux but not for Android. This commit is to also support Android. One interesting requirement for Android is that developers usually need to build *.so for the following 4 architectures. - armeabi-v7a - arm64-v8a - x86 - x86_64 With this commit, our GitHub Actions rule actually starts building 'libmozcjni.so' for the above 4 architectures, then archives them into a single zip file and upload it as the final artifact. [1]: bb50663 PiperOrigin-RevId: 561867498
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Now that both mac and Windows workflows build standalone installer packages when we push a new commit, we do not upload the installers as artifacts. Those who want to locally test the final binaries need to build the installer again locally.
It would be nice if GitHub actions upload the installers as artifacts when the build action is done.
Steps to reproduce
A use case would be:
Expected behavior
When the build actions for Windows and mac succeed, the installers built in the action become available in the result page.
Actual behavior
Currently no artifact is uploaded.
Version or commit-id
0ce1f9b
Additional context
See https://docs.github.com/en/actions/using-workflows/storing-workflow-data-as-artifacts for details.
A nice thing is that the download UI will be shown not only for commiters but also for other people as long as they sign with their GitHub account.
The text was updated successfully, but these errors were encountered: