Fix golangci-lint code issue

google · Jul 12, 2022 · 56833d8 · 56833d8
1 parent f38c61d
commit 56833d8
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/internal/metrics/metric.go b/internal/metrics/metric.go
@@ -209,7 +209,6 @@ func (m *Metric) RemoveDatum(labelvalues ...string) error {
 			if lv == olv {
 				// remove from the slice
 				m.LabelValues = append(m.LabelValues[:i], m.LabelValues[i+1:]...)
-				i--
 				delete(m.labelValuesMap, k)
 				break
 			}

diff --git a/internal/metrics/store_test.go b/internal/metrics/store_test.go
@@ -172,7 +172,7 @@ func TestExpireManyMetrics(t *testing.T) {
 			t.Error(err)
 		}
 		datum.SetInt(d, 1, time.Now().Add(-time.Hour))
-		lv := m.FindLabelValueOrNil([]string{strconv.Itoa(i)})
+		lv = m.FindLabelValueOrNil([]string{strconv.Itoa(i)})
 		if lv == nil {
 			t.Fatal("couldn't find lv")
 		}