Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PREFIX to make install #215

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Add PREFIX to make install #215

merged 1 commit into from
Mar 7, 2019

Conversation

worxli
Copy link
Contributor

@worxli worxli commented Mar 7, 2019

Commit #3bfdc27 broke the Dockerfile. I.e. COPY --from=builder /go/bin/mtail /usr/bin/mtail is trying to copy from a non-existent file.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2850

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.341%

Totals Coverage Status
Change from base Build 2843: 0.0%
Covered Lines: 3597
Relevant Lines: 5422

💛 - Coveralls

@worxli
Copy link
Contributor Author

worxli commented Mar 7, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@jaqx0r
Copy link
Contributor

jaqx0r commented Mar 7, 2019

Thanks! Docker builds don't get tested by ci yet

@jaqx0r jaqx0r merged commit 1156d8b into google:master Mar 7, 2019
@worxli worxli deleted the fix-dockerfile branch March 8, 2019 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants