-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Select the correct sha for the test results when running from a post-merge action. #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark ResultBenchmark diff with base
|
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #662 +/- ##
==========================================
- Coverage 56.83% 56.64% -0.19%
==========================================
Files 66 16 -50
Lines 7411 1008 -6403
==========================================
- Hits 4212 571 -3641
+ Misses 2947 408 -2539
+ Partials 252 29 -223
Continue to review full report at Codecov.
|
…ost-merge action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract a SHA from post-merge on main.
Set the shell explicitly to
bash
which means we also correctlyif
and thus are likely to succeed aspwsh
is a totally different language! Fun times in Github Actions.