Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rules to fix failing conversions #24

Merged
merged 1 commit into from
Oct 24, 2018

Conversation

theinlinkyaw
Copy link
Contributor

This update fixed issues for some U -> Z failing conversions.

input : U -> "မြှင့် မြှိက် ငြှိုး ခြုံ မြှူ မြှီ နြွဲ နြွေု"
expected : Z -> "ျမႇင့္ ၿမႇိက္ ၿငႇိဳး ၿခံဳ ျမႇဴ ၿမႇီ ႃႏြဲ ေႁႏြဳ"
actual : Z -> "ၿမွင့္ ႃမွိက္ ႃငွိုး ႃခံု ၿမွူ ႃမွီ ျနဲြ ျနြေု"

Also change some test case for the update to pass the test.

@sffc
Copy link
Collaborator

sffc commented Sep 28, 2018

Thanks for the PR! Can you take a look at the failing node.js test and push a fix to your branch?

@theinlinkyaw
Copy link
Contributor Author

Thanks for the PR! Can you take a look at the failing node.js test and push a fix to your branch?

Dear @sffc,

The node.js is failing because make compatU2Z put extra text in genconvert/output/udhr_mya_zawgyi_out.txt. After I redo make compatU2Z, the node.js test is pass. I do not know what cause the behavior. I alter the commit and force push the fix.

Copy link
Collaborator

@sven-oly sven-oly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing these cases.

@sven-oly sven-oly merged commit ec4011b into google:master Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants