Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python client #46

Merged
merged 5 commits into from
Apr 15, 2020
Merged

Add python client #46

merged 5 commits into from
Apr 15, 2020

Conversation

blackblitz
Copy link
Contributor

Python client which implements ZawgyiDetector was added, and Makefile and .travis,yml were updated accordingly. Tested and passed on Travis CI. However, the C++ client keeps getting file DOWNLOAD HASH mismatch while downloading ICU4C. Please check the metadata in setup.py. If this PR is accepted, we should make it available on PyPI.

sffc
sffc approved these changes Apr 15, 2020
View reviewed changes
Copy link
Collaborator

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I reviewed the code and it looks great!

The C++ Travis failure should be fixed by #45.

@sffc
Copy link
Collaborator

sffc commented Apr 15, 2020

I think we should push this to PyPI. You can create the package, but please also give publish rights to the user google-myanmar-tools-user so that we can push updates in the future if required.

@sffc sffc merged commit 75c59af into google:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@blackblitz @sffc