Use DYLD_LIBRARY_PATH instead of rpath for Swift client #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the Swift tests, I realized it's better to set `DYLD_LIBRARY_PATH` in the environment to find `libmyanmartools.dylib`, rather than hard-coding rpath to the absolute path of the build directory. Also, I forgot to quote $(CURDIR) so it would fail if the current directory had a space in it.
sffc
approved these changes
Jun 19, 2020
sffc
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized the Swift client doesn't need to hack rpath to find the C++ client library; we can just set
DYLD_LIBRARY_PATHin the environment to find it instead.Also, I fixed a small bug (quote
$(CURDIR)to fix the build if the current directory has a space).