-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-implement python client #65
Conversation
This comment has been minimized.
This comment has been minimized.
@googlebot I fixed it. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Travis CI isn't setting commit statuses right now; while we set up an alternative, please check the build status manually:
https://travis-ci.org/github/google/myanmar-tools
There is a build error in the Python build. Can you take a look? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. This is a good change because it eliminates the numpy dependency. CC @blackblitz, original author of this code; WDYT?
I think it is good. In case you didn't notice, the author of this PR and the original author of the code are the same person. |
Great! Let's merge it then. We should release this as version 1.2.1 on PyPI. I will make a PR to bump the version number. |
I bumped and tagged the new version directly on the master branch: https://github.com/google/myanmar-tools/releases/tag/v1.2.1%2Bpy Uploaded to PyPI: |
This re-implementation makes the following improvements:
numpy
but now usesarray
in the standard library)exp
, which happens with very long Myanmar Unicode input strings)src
directory is type-checked withmypy
in strict mode)