neper: don't collect latency stats in tcp_crr server (#22) #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For tcp_crr server, a new flow is created for each short-lived connection. If we collect stats, flow's neper_stat will be added to worker thread's neper_stats, and won't be freed until the worker thread ends. It will use a lot of memory (~1GB/sec) and cause test failures. For other four workloads including tcp_crr client, the number of flows is specified by command line flag, so the memory useage is stable. Fixes: 253d3b4 ("neper: collect stats in *rr servers")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For tcp_crr server, a new flow is created for each short-lived
connection. If we collect stats, flow's neper_stat will be added
to worker thread's neper_stats, and won't be freed until the worker
thread ends. It will use a lot of memory (~1GB/sec) and cause test
failures.
For other four workloads including tcp_crr client, the number of
flows is specified by command line flag, so the memory useage is
stable.
Fixes: 253d3b4 ("neper: collect stats in *rr servers (#22)")