Skip to content
This repository has been archived by the owner on May 20, 2020. It is now read-only.

Make go:linkname work for other architectures #11

Closed
wants to merge 1 commit into from

Conversation

antong
Copy link
Contributor

@antong antong commented Sep 24, 2018

Add an empty assembly file to make the go:linkname directive
work on other architectures than those that have .s files
included.

Without this I get:

netstack\sleep\sleep_unsafe.go:88:6: missing function body
netstack\sleep\sleep_unsafe.go:91:6: missing function body

Add an empty assembly file to make the go:linkname directive
work on other architectures than those that have .s files
included.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@antong
Copy link
Contributor Author

antong commented Sep 24, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@iangudger
Copy link
Contributor

Thanks for the patch. Unfortunately, our infrastructure doesn't support accepting pull requests here. Please use Gerrit to send a CL to the gVisor repository.

@antong
Copy link
Contributor Author

antong commented Sep 25, 2018

OK, I had misunderstood that this was upstream for gVisor and not the other way around. Anyway, I now noticed that the issue this PR fixes actually was already fixed for arm64, by commit_arm64.s. The naming of that file was a bit unfortunate, as naming it e.g., dummy.s would have fixed it for all architectures and not only arm64.

@antong antong closed this Sep 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants