This repository has been archived by the owner on May 20, 2020. It is now read-only.
rawfile: don't try to call entersyscallblock #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Directly calling runtime.entersyscallblock was never safe. In the upcoming 1.12 release, it breaks: github.com/google/netstack/tcpip/link/rawfile.blockingPoll: relocation target runtime.entersyscallblock not defined for ABI0 (but is defined for ABIInternal) github.com/google/netstack/tcpip/link/rawfile.blockingPoll: relocation target runtime.entersyscallblock not defined for ABI0 (but is defined for ABIInternal) Rewrite the code to call unix.Poll instead. This will lose the minor benefit of entersyscallblock; there is no supported way to call that outside the runtime package.
|
Sending to upstream instead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directly calling runtime.entersyscallblock was never safe. In the
upcoming 1.12 release, it breaks:
github.com/google/netstack/tcpip/link/rawfile.blockingPoll: relocation target runtime.entersyscallblock not defined for ABI0 (but is defined for ABIInternal)
github.com/google/netstack/tcpip/link/rawfile.blockingPoll: relocation target runtime.entersyscallblock not defined for ABI0 (but is defined for ABIInternal)
Rewrite the code to call unix.Poll instead. This will lose the minor
benefit of entersyscallblock; there is no supported way to call that
outside the runtime package.