Skip to content
This repository has been archived by the owner on May 20, 2020. It is now read-only.

add support for icmp #22

Closed
wants to merge 4 commits into from
Closed

add support for icmp #22

wants to merge 4 commits into from

Conversation

halcyon316
Copy link

Now the icmp endpoint in the transport folder has no public function to call, so I added a forward.go file to the udp package. In the process I found that the return value of newEndPoint should be *endpoint instead of tcpip.EndPoint, otherwise the RegisterTransportEndpoint will pass. The return value obtained by newEndpoint cannot be passed in. It will prompt cannot use ep (type tcpip.Endpoint) as type stack.TransportEndpoint in argument to r.stack.RegisterTransportEndpoint

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@halcyon316 halcyon316 closed this Jun 8, 2019
@halcyon316 halcyon316 reopened this Jun 8, 2019
@halcyon316 halcyon316 closed this Jun 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants