Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #43
Appended mutex to avoid race condition in threaded mode.
Most dangerous part is handling subresources(
subresource_fetch_handler
), because every subresources could arrive simultaneously.So I appended mutex lock and unlock.
note: Nginx seems to support Windows environment, but wrapped API's (
ngx_thread_mutex_t
) is not exposed to plugin developers. And originally, this module does not support Windows.