Prevent spinning when progress is not being made. #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #80 at least for my examples.
|
Hello. Thanks for the PR. So, it will resolve the tight loop (when brotli waits for output buffer to be consumed, but the filter below does not make any progress). But the question is - will nginx react as expected. IIRC, we already got problem with returning NGX_AGAIN... Will try to find what was it and update this comment soon. |
|
Is was about NGX_OK vs NGX_DONE. LGTM. Will land the PR, but reopen the issue, to gather the feedback from other users. Thanks again. |
|
Thanks for the progress! I'm pushing this to production now, and will let you know if the problem comes back. 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80 at least for my examples.