Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow @RequestScope on methods #15

Closed
wants to merge 1 commit into from
Closed

Allow @RequestScope on methods #15

wants to merge 1 commit into from

Conversation

wolfgangmeyers
Copy link
Contributor

By default, a provider method is invoked each time a
provided object is injected. This allows provider methods
in dagger modules to provide request-scoped objects.
For more details see:
https://guides.codepath.com/android/Dependency-Injection-with-Dagger-2#scopes

Allow @requestScope on methods
2171f42 
By default, a provider method is invoked each time a
provided object is injected. This allows provider methods
in dagger modules to provide request-scoped objects.
For more details see:
https://guides.codepath.com/android/Dependency-Injection-with-Dagger-2#scopes
@wolfgangmeyers wolfgangmeyers mentioned this pull request Apr 13, 2016
Closed
@wolfgangmeyers
Copy link
Contributor Author

reviewer: @jart

@wolfgangmeyers
Copy link
Contributor Author

Well, looks like she is on vacation. Anyone else want to look at this? @r-g-r or @CydeWeys maybe? :)

@CydeWeys
Copy link
Member

Going through our internal process now.

@CydeWeys
Copy link
Member

CydeWeys commented Jun 6, 2016

Submitted.

@CydeWeys CydeWeys closed this Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wolfgangmeyers @CydeWeys @googlebot