New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore resaveAllEppResourcesPipeline as a cloud task #1953
Restore resaveAllEppResourcesPipeline as a cloud task #1953
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's hold off with this. I have doubt about that pipeline. Specifically:
nomulus/core/src/main/java/google/registry/beam/resave/ResaveAllEppResourcesPipeline.java
Line 196 in 71a8579
options.setIsolationOverride(TransactionIsolationLevel.TRANSACTION_REPEATABLE_READ); |
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @jianglai)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be fine? Each resource is projected into the future independently so there should be no possibility of serialization anomalies.
Reviewable status: 0 of 2 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about concurrent updates. Since we always update the timestamp, it should be okay.
Reviewable status: 0 of 2 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, if you are concerned about the blast radius of this job, consider enabling it in sandbox first and verify the results before enabling it on production.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ptkach)
This change is