Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore resaveAllEppResourcesPipeline as a cloud task #1953

Merged
merged 1 commit into from Mar 13, 2023

Conversation

ptkach
Copy link
Collaborator

@ptkach ptkach commented Mar 3, 2023

This change is Reviewable

@ptkach ptkach requested review from jianglai and weiminyu March 3, 2023 21:48
Copy link
Collaborator

@weiminyu weiminyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold off with this. I have doubt about that pipeline. Specifically:

options.setIsolationOverride(TransactionIsolationLevel.TRANSACTION_REPEATABLE_READ);

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @jianglai)

Copy link
Collaborator

@jianglai jianglai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be fine? Each resource is projected into the future independently so there should be no possibility of serialization anomalies.

Reviewable status: 0 of 2 files reviewed, all discussions resolved

Copy link
Collaborator

@weiminyu weiminyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about concurrent updates. Since we always update the timestamp, it should be okay.

Reviewable status: 0 of 2 files reviewed, all discussions resolved

Copy link
Collaborator

@weiminyu weiminyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 files reviewed, all discussions resolved

Copy link
Collaborator

@jianglai jianglai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, if you are concerned about the blast radius of this job, consider enabling it in sandbox first and verify the results before enabling it on production.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ptkach)

@ptkach ptkach merged commit e60ad58 into google:master Mar 13, 2023
@ptkach ptkach deleted the restoreResaveAllEppResourcesPipeline branch October 3, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants