Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move console global loader, fix table scrollers #2494

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

ptkach
Copy link
Collaborator

@ptkach ptkach commented Jul 10, 2024

This change is Reviewable

@ptkach ptkach requested a review from gbrodman July 10, 2024 19:10
Copy link
Collaborator

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ptkach)


-- commits line 2 at r1:
commit message should conform to the guidelines e.g. https://engdoc.corp.google.com/eng/doc/devguide/coding/review/developer/cl-descriptions.md?cl=head

@ptkach ptkach changed the title Console move global loader, fix table scrollers Move console global loader, fix table scrollers Jul 11, 2024
Copy link
Collaborator Author

@ptkach ptkach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @gbrodman)


-- commits line 2 at r1:

Previously, gbrodman wrote…

commit message should conform to the guidelines e.g. https://engdoc.corp.google.com/eng/doc/devguide/coding/review/developer/cl-descriptions.md?cl=head

Updated

Copy link
Collaborator

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ptkach)

Copy link
Collaborator

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ptkach)

@ptkach ptkach added this pull request to the merge queue Jul 12, 2024
Merged via the queue into google:master with commit 5f9f157 Jul 12, 2024
9 checks passed
@ptkach ptkach deleted the consolePreRelease branch July 12, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants