New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow AppEngine deployment to qa environment #986
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @weiminyu)
build.gradle, line 124 at r1 (raw file):
// the root project. def environments = ['production', 'sandbox', 'alpha', 'crash', 'qa']
I think you may need to add this to /projects.gradle, as well? In any case, you probably should.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @weiminyu)
build.gradle, line 124 at r1 (raw file):
Previously, mindhog (Michael Muller) wrote…
I think you may need to add this to /projects.gradle, as well? In any case, you probably should.
TBH, I'm not sure why we don't extract this from projects.gradle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @weiminyu)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @mindhog)
build.gradle, line 124 at r1 (raw file):
Previously, mindhog (Michael Muller) wrote…
TBH, I'm not sure why we don't extract this from projects.gradle.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mindhog)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mindhog)
This depends on a PR in the internal repo.
This change is