ldapsource.py expects modifyTimestamp instead of modifyTimeStamp

[jtpereyda]

Stack trace; notice 'modifyTimeStamp': ['20150920045950.0Z'] on line 2 and the exception at the bottom: KeyError: 'modifyTimestamp':

DEBUG:LdapSource:searching for base='dc=ad,dc=selinc,dc=com', filter='(&(objectCategory=Person)(uidNumber=*)(gidNumber=*))', scope=2, attrs=['uid', 'shadowLastChange', 'shadowMin', 'shadowMax', 'shadowWarning', 'shadowInactive', 'shadowExpire', 'shadowFlag', 'userPassword', 'modifyTimestamp']
obj:{'uid': ['timti'], 'modifyTimeStamp': ['20150920045950.0Z']}
Traceback (most recent call last):
  File "/usr/local/bin/nsscache", line 33, in <module>
    return_value = nsscache_app.Run(sys.argv[1:], os.environ)
  File "/usr/local/lib/python2.7/dist-packages/nss_cache/app.py", line 240, in Run
    retval = command_callable().Run(conf=conf, args=args)
  File "/usr/local/lib/python2.7/dist-packages/nss_cache/command.py", line 230, in Run
    force_lock=options.force_lock)
  File "/usr/local/lib/python2.7/dist-packages/nss_cache/command.py", line 312, in UpdateMaps
    force_write=force_write)
  File "/usr/local/lib/python2.7/dist-packages/nss_cache/update/updater.py", line 265, in UpdateFromSource
    force_write, location=None)
  File "/usr/local/lib/python2.7/dist-packages/nss_cache/update/map_updater.py", line 75, in UpdateCacheFromSource
    location=location)
  File "/usr/local/lib/python2.7/dist-packages/nss_cache/sources/source.py", line 69, in GetMap
    return self.GetShadowMap(since)
  File "/usr/local/lib/python2.7/dist-packages/nss_cache/sources/ldapsource.py", line 325, in GetShadowMap
    since=since)
  File "/usr/local/lib/python2.7/dist-packages/nss_cache/sources/ldapsource.py", line 507, in GetUpdates
    obj_ts = self.FromLdapToTimestamp(obj['modifyTimestamp'][0])
KeyError: 'modifyTimestamp'

The lookup expects modifyTimestamp, but LDAP gives modifyTimeStamp.

The quick fix is to change the string in ldapsource.py (recommend changing entire file for consistency).

The better fix would be to make comparisons case-insensitive. Hypothetically, an LDAP server could send us modifyTimestamp.

[jtpereyda]

It occurred to me that this bug might be a result of my LDAP server being different. The insensitive lookup option is probably much safer.

[jaqx0r]

What server version are you using?

On Fri, 2 Oct 2015, 05:58 Joshua Pereyda notifications@github.com wrote:

It occurred to me that this bug might be a result of my LDAP server being
different. The insensitive lookup option is probably much safer.

—
Reply to this email directly or view it on GitHub
#52 (comment).

[jtpereyda]

Active Directory. My IS department tells me they're Server 2012 and Server 2008 R2.

[jtpereyda]

Update: the change-to-modifyTimeStamp does indeed for me, but I think the patch should be more generic.