This repository has been archived by the owner on Nov 5, 2019. It is now read-only.
100% coverage for oauth2client.tools #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import threading | ||
| import unittest2 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Thanks a lot for doing this! |
|
No worries. This module is particularly crufty, so it's important to have these tests before we try to clean it up. |
|
👍 👍 👍 Yaaaaas |
theacodes
force-pushed
the
test-coverage-tools
branch
from
6becea0
to
29c369a
Compare
|
All comments addressed. Many more tests, but I tried to keep some of the repetition to a minimum. |
| @@ -1,12 +1,22 @@ | |||
| """Unit tests for oauth2client.tools.""" | |||
| import socket | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM (pending license) Not sure if @nathanielmanistaatgoogle has a preference for module docstrings for tests. It's irrelevant to me. |
|
Looks good (pending license header). |
theacodes
force-pushed
the
test-coverage-tools
branch
from
29c369a
to
35aabeb
Compare
|
License header added. Will merge once travis is green. |
theacodes
pushed a commit
that referenced
this pull request
Mar 16, 2016
100% coverage for oauth2client.tools
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #212.