Add urllib3 transport #659

theacodes · 2016-09-26T18:29:35Z

No description provided.

oauth2client/transport/urllib3.py

+        refresh_status_codes (Sequence): Which HTTP status code indicate that
+            credentials should be refreshed and the request should be retried.
+    """
+    def __init__(self, http, credentials, refresh_status_codes):


oauth2client/transport/urllib3.py

+        self.refresh_status_codes = refresh_status_codes
+
+    def urlopen(self, method, url, body=None, headers=None,
+                _credential_refresh_attempt=0, **kwargs):


oauth2client/transport/urllib3.py

+            headers = self.headers
+
+        # Copy the request headers because this may be called recursively.
+        request_headers = _helpers.initialize_headers(headers).copy()


oauth2client/transport/urllib3.py

+    return urllib3.PoolManager(*args, **kwargs)
+
+
+class AuthorizedHttp(request.RequestMethods):


oauth2client/transport/urllib3.py

+        # A stored token may expire between the time it is retrieved and
+        # the time the request is made, so we may need to try twice.
+        # The reason urllib3's retries aren't used is because they
+        # don't allow you to modify the request headers. :/


oauth2client/transport/urllib3.py

+
+    The behavior is transport-specific, but all transports will return a new
+    http object that provides credentials to requests and refreshed credentials
+    when a response in REFRESH_STATUS_CODES is received.


oauth2client/transport/urllib3.py

+    The arguments match :func:`oauth2client.transport.request`. Additional
+    arguments are passed through to
+    :meth:`urllib3.request.RequestMethods.request`.
+


oauth2client/transport/urllib3.py

+        urllib3.response.HTTPResponse: The HTTP response.
+    """
+    response = http.request(method, uri, body=body, headers=headers, **kwargs)
+    return response


tests/transport/test_transport_compliance.py

@@ -24,7 +24,7 @@
 NXDOMAIN = 'test.invalid'


-def test_server_app():
+def server_app():


tests/transport/test_urllib3_transport.py

+
+import urllib3
+import urllib3.exceptions
+import mock


dhermes

LGTM

Basic urllib3 transport

626183e

theacodes assigned dhermes Sep 26, 2016

googlebot added the cla: yes label Sep 26, 2016

dhermes reviewed Sep 26, 2016

View reviewed changes

theacodes mentioned this pull request Sep 26, 2016

Retry classes should be able to modify the request headers urllib3/urllib3#984

Open

Address review comments

efda9c8

theacodes force-pushed the tr-4-urllib3-transport branch from a8c9095 to efda9c8 Compare September 26, 2016 19:38

Fix missing docs

c58e672

dhermes approved these changes Sep 26, 2016

View reviewed changes

theacodes merged commit 1ac4645 into googleapis:transport-refactor Sep 26, 2016

theacodes deleted the tr-4-urllib3-transport branch September 26, 2016 20:44

google-admin unassigned dhermes Sep 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add urllib3 transport #659

Add urllib3 transport #659

theacodes commented Sep 26, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dhermes left a comment

		return urllib3.PoolManager(args, *kwargs)


		class AuthorizedHttp(request.RequestMethods):

Add urllib3 transport #659

Add urllib3 transport #659

Conversation

theacodes commented Sep 26, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dhermes left a comment

Choose a reason for hiding this comment