Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

round capacity up to 4096 frames to get FAST capture path #183

Closed
philburk opened this issue Aug 8, 2018 · 3 comments
Closed

round capacity up to 4096 frames to get FAST capture path #183

philburk opened this issue Aug 8, 2018 · 3 comments
Assignees
@philburk
Labels
P1 high priority
Milestone
v1.0

Comments

@philburk
Copy link
Collaborator

philburk commented Aug 8, 2018

An explicit buffer capacity request != 4096 can result in a Legacy AudioRecord stream not getting a FAST track.
This may be specific to P and earlier.
@philburk philburk added this to the v1.0 milestone Aug 14, 2018
@dturner
Copy link
Collaborator

dturner commented Sep 6, 2018

Desired behaviour is that the capacity request is a minimum and should be rounded up to 4096 to ensure a FAST track is obtained.

philburk pushed a commit that referenced this issue Sep 18, 2018
round capacity up to get a FAST input path
dc5ed59 
Workaround for a limitation in AudioFlinger on Legacy AAudio data path.
INPUT stream capacity must be 4096 to get a FAST track.

Fixes #183
@philburk philburk mentioned this issue Sep 18, 2018
Merged
@philburk
Copy link
Collaborator Author

Testing this requires requesting a capacity in an INPUT stream < 4096.
The issue only involves Legacy Mode so you must enter:
adb root
adb shell setprop aaudio.mmap_policy 1

Also on OC MR1 you should request PCM16 data format to get FAST track.

The final stream should have performance mode LowLatency.

@philburk philburk added the P1 high priority label Sep 18, 2018
@philburk
Copy link
Collaborator Author

This was fixed in Q with ag/7116429

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philburk philburk

Labels
P1 high priority
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
2 participants
@dturner @philburk