Add setPackageName and setAttributionTag to the Oboe builder #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like certain types of streams don't play well with setting the package name. For example, Tap To Tone Latency works perfectly but Glitch Test has some weird bugs. When running the unit tests, some randomly fail setting the package name before |
philburk
requested changes
Jul 13, 2021
|
@philburk Thanks for adding comments! I removed all of the setters. Let me know if this looks good |
|
These features were added to AAudio to allow more detailed logging. |
philburk
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Android 12, we added an ability to set Package Names and Attribution Tags to AAudio. We are also doing this in Oboe.
Note that getting the values comes from the context (Context#getPackageName()/Context#getAttributionTag())
Fixes #1282
Tested via:
Built OboeTester
Built and ran unit tests