Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use AAudio unless running on Android 8.1 or higher #51

Merged
merged 1 commit into from Feb 6, 2018

Conversation

mnaganov
Copy link
Collaborator

@mnaganov mnaganov commented Feb 6, 2018

From #40, it seems that AAudio
on Android 8.0 isn't stable enough. As a safety measure, always
fall back to OpenSL ES on it.

From #40, it seems that AAudio
on Android 8.0 isn't stable enough. As a safety measure, always
fall back to OpenSL ES on it.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@mnaganov
Copy link
Collaborator Author

mnaganov commented Feb 6, 2018

Please note that I actually work for Google, just using my personal GitHub account. I've signed the CLA just in case, but I believe it's not really needed in this case.

@googlebot
Copy link

CLAs look good, thanks!

@dturner
Copy link
Collaborator

dturner commented Feb 6, 2018

Tested on Pixel (emulator) running API 26. Result: OpenSL ES is used - PASS
Tested on Pixel 2 running API 27. Result: AAudio is used - PASS

+2 Approved

@dturner dturner closed this Feb 6, 2018
@dturner dturner reopened this Feb 6, 2018
@dturner dturner merged commit a2b8690 into master Feb 6, 2018
@dturner dturner deleted the fix-issue-40 branch February 12, 2018 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants