Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate retype #71

Merged
merged 1 commit into from
May 25, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## 0.22.1+3

Update implementations of the `cast()` and the deprecated `retype()` methods.
* The `retype()` method on List and Map is deprecated and will be removed.
* The `cast()` method should do what the `retype()` method did.

## 0.22.1+2

* Widen dependency on quiver to include v0.29.
Expand Down
1 change: 1 addition & 0 deletions lib/src/observable_list.dart
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ class ObservableList<E> extends ListBase<E> with Observable {
/// must be instance of [T] to be valid arguments to the adding function,
/// and they must be instances of [E] as well to be accepted by
/// this list as well.
@deprecated
@override
// ignore: override_on_non_overriding_method
ObservableList<T> retype<T>() => cast<T>();
Expand Down
1 change: 1 addition & 0 deletions lib/src/observable_map.dart
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ class ObservableMap<K, V> extends Observable implements Map<K, V> {
return ObservableMap.castFrom<K, V, K2, V2>(this);
}

@deprecated
@override
// ignore: override_on_non_overriding_method
ObservableMap<K2, V2> retype<K2, V2>() {
Expand Down