Fix ChangeNotifier generic typing issue #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Record.None is not typesafe for any subclasses of ChangeNotifier that subclass the generic. Proposed solution is to output a `ChangeRecords extends List<ChangeRecord>` with additional metadata to indicate the change is ANY or NONE. Advantage of this change is that it is backwards compatible with existing code while fixing type exceptions for future code.
buhhy
changed the title
|
Thanks! Could you push one more change that includes a description of the new features/behavior in the CHANGELOG.md? I'll handle updating the versions and publishing it once this is merged. |
nshahan
approved these changes
Dec 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ChangeNotifier generic typing issue - ChangeRecord.ANY and ChangeRecord.None is not typesafe for any subclasses of ChangeNotifier that subclass the generic.
Proposed solution is to output a
ChangeRecords extends List<ChangeRecord>with additional metadata to indicate the change is ANY or NONE.Advantage of this change is that it is backwards compatible with existing code while fixing type exceptions for future code.