Skip to content

Commit

Permalink
Improve method name
Browse files Browse the repository at this point in the history
  • Loading branch information
mherrmann committed Aug 5, 2021
1 parent f64c29a commit ff44efe
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion omaha/common/config_manager.cc
Expand Up @@ -1807,7 +1807,7 @@ bool ConfigManager::AlwaysAllowCrashUploads() const {
return always_allow_crash_uploads != 0;
}

bool ConfigManager::VerifyPayloadAuthenticodeSignature() const {
bool ConfigManager::ShouldVerifyPayloadAuthenticodeSignature() const {
DWORD disabled_in_registry = 0;
RegKey::GetValue(MACHINE_REG_UPDATE_DEV,
kRegValueDisablePayloadAuthenticodeVerification,
Expand Down
2 changes: 1 addition & 1 deletion omaha/common/config_manager.h
Expand Up @@ -462,7 +462,7 @@ class ConfigManager {

// Returns whether the Authenticode signature of update payloads should be
// verified.
bool VerifyPayloadAuthenticodeSignature() const;
bool ShouldVerifyPayloadAuthenticodeSignature() const;

// Returns the number of crashes to upload per day.
int MaxCrashUploadsPerDay() const;
Expand Down
2 changes: 1 addition & 1 deletion omaha/goopdate/download_manager.cc
Expand Up @@ -535,7 +535,7 @@ HRESULT DownloadManager::CachePackage(const Package* package,
PackageCache::Key key(app_id, version, package_name);

HRESULT hr = E_UNEXPECTED;
if (ConfigManager::Instance()->VerifyPayloadAuthenticodeSignature()) {
if (ConfigManager::Instance()->ShouldVerifyPayloadAuthenticodeSignature()) {
hr = EnsureSignatureIsValid(*source_file_path);
if (FAILED(hr)) {
CORE_LOG(LE, (_T("[EnsureSignatureIsValid failed][%s][0x%08x]"),
Expand Down

0 comments on commit ff44efe

Please sign in to comment.