Add max code length for Ruby library.

google · Feb 14, 2019 · ded31e2 · ded31e2
1 parent 0b1ec08
commit ded31e2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/ruby/lib/plus_codes.rb b/ruby/lib/plus_codes.rb
@@ -14,6 +14,9 @@ module PlusCodes
   # for identifying buildings. This excludes prefix and separator characters.
   PAIR_CODE_LENGTH = 10
 
+  # Maximum number of digits to process in a plus code.
+  MAX_CODE_LENGTH = 15
+
   # The character used to pad a code
   PADDING = '0'.freeze
 

diff --git a/ruby/lib/plus_codes/open_location_code.rb b/ruby/lib/plus_codes/open_location_code.rb
@@ -45,6 +45,9 @@ def encode(latitude, longitude, code_length = PAIR_CODE_LENGTH)
       raise ArgumentError,
       "Invalid Open Location Code(Plus+Codes) length: #{code_length}" if invalid_length?(code_length)
 
+      if code_length > MAX_CODE_LENGTH
+        code_length = MAX_CODE_LENGTH
+      end
       latitude = clip_latitude(latitude)
       longitude = normalize_longitude(longitude)
       latitude -= precision_by_length(code_length) if latitude == 90
@@ -82,7 +85,7 @@ def decode(code)
       lng_resolution = 400.to_r
 
       digit = 0
-      while digit < code.length
+      while digit < [code.length, MAX_CODE_LENGTH].min
         if digit < PAIR_CODE_LENGTH
           lat_resolution /= 20
           lng_resolution /= 20