Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing warnings #18

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Fixing warnings #18

merged 1 commit into from
Aug 12, 2022

Conversation

mohanad0mohamed
Copy link
Contributor

@mohanad0mohamed mohanad0mohamed commented Aug 3, 2022

Fixes google/gf180mcu-pdk#20
Fixes google/gf180mcu-pdk#22
Fixes #10

Added the extra.css and ext.py (part of conf.py) as suggested here google/gf180mcu-pdk#39 (review)

  • Built locally successfully

Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments and then this can be merged.

docs/_static/extra.css Show resolved Hide resolved
docs/ext.py Outdated Show resolved Hide resolved
docs/ext.py Outdated Show resolved Hide resolved
@mohanad0mohamed
Copy link
Contributor Author

@mithro I have made the requested changes. Also, I have fixed the warnings of this repository also.

Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mithro mithro merged commit f84e185 into google:main Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants