exe_test: Use assertNotIn (#894)

Use assertNotIn instead of assertFalse(x in y) because it will give better error messages.
google · Jul 12, 2019 · 35f46b7 · 35f46b7
1 parent 1993317
commit 35f46b7
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/test/core/exe_test.py b/test/core/exe_test.py
@@ -467,7 +467,7 @@ def test_stop_on_first_failure_phase(self):
     self.assertTrue(record.outcome, Outcome.FAIL)
     # Verify phase_one was not run
     ran_phase = [phase.name for phase in record.phases]
-    self.assertFalse('phase_one' in ran_phase)
+    self.assertNotIn('phase_one', ran_phase)
     # Teardown function should be executed.
     self.assertTrue(ev.wait(1))
     executor.close()
@@ -494,7 +494,7 @@ def test_conf_stop_on_first_failure_phase(self):
     self.assertTrue(record.outcome, Outcome.FAIL)
     # Verify phase_one was not run
     ran_phase = [phase.name for phase in record.phases]
-    self.assertFalse('phase_one' in ran_phase)
+    self.assertNotIn('phase_one', ran_phase)
     # Teardown function should be executed.
     self.assertTrue(ev.wait(1))
     executor.close()