[CMake] USE_SCIP=OFF not working

[joshuaeckroth]

libscip (SCIP optimization library) is suddenly required for any cmake C++ build, ignoring USE_SCIP option.

This line: https://github.com/google/or-tools/blame/stable/cmake/cpp.cmake#L222 requires libscip, ignoring the USE_SCIP setting. Removing this line allows a successful build (assuming one does not wish to use scipopt library).

[joshuaeckroth]

This is important for commercial uses since SCIP's license is not open source.

[Mizux]

For release v7.8 we get the agreement to integrate SCIP in our build process, but yes you still need to comply with SCIP license limitation if you want to use it (only the LinearSolver component use it).

Having the ability to disable SCIP (i.e. having USE_SCIP=OFF) is a target goal, I'll try to fix it ASAP

Should reuse this instead:

or-tools/ortools/linear_solver/CMakeLists.txt

Line 29 in a0a5669

$<$<BOOL:${USE_SCIP}>:libscip>

[lperron]

Starting with or-tools 7.8, SCIP is not built in by default. To use it, you must comply with the license. But this is not required for just compiling it. Laurent Perron | Operations Research | lperron@google.com | (33) 1 42 68 53 00 Le jeu. 6 août 2020 à 14:43, Joshua Eckroth <notifications@github.com> a écrit :

…

This is important for commercial uses since SCIP's license is not open source. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2129 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACUPL3LHNWWSKPYHAEWCXQ3R7KQQDANCNFSM4PWROLOQ> .

[lperron]

Do you think this is still a problem ?
I checked with the SCIP team before doing the change.

[lperron]

On master, I have added BUILD_SCIP=OFF in commented form in Makefile.local. Uncommenting it, and then *make clean*, then* make all* will build or-tools without SCIP support. Laurent Perron | Operations Research | lperron@google.com | (33) 1 42 68 53 00 Le jeu. 6 août 2020 à 15:43, Laurent Perron <lperron@google.com> a écrit :

…

Starting with or-tools 7.8, SCIP is not built in by default. To use it, you must comply with the license. But this is not required for just compiling it. Laurent Perron | Operations Research | ***@***.*** | (33) 1 42 68 53 00 Le jeu. 6 août 2020 à 14:43, Joshua Eckroth ***@***.***> a écrit : > This is important for commercial uses since SCIP's license is not open > source. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#2129 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ACUPL3LHNWWSKPYHAEWCXQ3R7KQQDANCNFSM4PWROLOQ> > . >