New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python CP-SAT type hints #3668
Python CP-SAT type hints #3668
Conversation
Thank you for opening this review ! That's a great start. I added some comments right now with additional typing from the top of my mind. But there are many more missing, even in other files 🤔 What would be the best way to help you cover all the definitions ? |
Thanks for the help offer and suggestions! @oulianov But I believe I just need some time to figure out the best type definitions for some of the more complex interfaces, eg:
And test them thoroughly. |
For sure, totally understand. Wish you the best, feel free to reach out |
Hi, Any change of pushing this ? |
My bad, never saw the conflicts, should be ready to review/merge now |
Work in progress, opened as draft pull request.
Tasks:
cmh.is_integral
), Literal (IntVar
+_NotBooleanVariable
+Integral
), Arc, etcortools/sat/samples