Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let the plugin not use Provider.forUseAtConfigurationTime() #29

Closed
eskatos opened this issue Jan 28, 2023 · 2 comments · Fixed by #30
Closed

Let the plugin not use Provider.forUseAtConfigurationTime() #29

eskatos opened this issue Jan 28, 2023 · 2 comments · Fixed by #30
Assignees
@ejona86

Comments

@eskatos
Copy link

eskatos commented Jan 28, 2023

With the 0.9.2 plugin.

The plugin uses Provider.forUseAtConfigurationTime() which was softly deprecated (@Deprecated) since Gradle 7.4.
Since Gradle 7.4 it is a noop anyway.

We would like to start nagging users about the deprecation soon (early in 8.x to be able to remove it in Gradle 9.0).
@eskatos eskatos mentioned this issue Jan 28, 2023
Closed
@ejona86
Copy link
Collaborator

ejona86 commented Feb 3, 2023

Looks like it isn't actually used in this project. Instead it is used in osdetector-gradle-plugin. But you're in luck, because I'm a maintainer of that plugin as well.

Since Gradle 7.4 it is a noop anyway.

Okay, so I guess we'll version detect and disable it starting with 7.4.

Let me see if I can transfer this issue to the other repo.

@ejona86 ejona86 transferred this issue from google/protobuf-gradle-plugin Feb 3, 2023
ejona86 added a commit to ejona86/osdetector-gradle-plugin that referenced this issue Feb 3, 2023
@ejona86
Avoid calling Provider.forUseAtConfigurationTime() for Gradle >= 7.4
a888621 
Gradle will start warning about the now-noop method in 8.x, for removal
in 9.0.

Fixes google#29
@ejona86 ejona86 mentioned this issue Feb 3, 2023
Merged
@ejona86 ejona86 self-assigned this Feb 3, 2023
ejona86 added a commit that referenced this issue Feb 8, 2023
@ejona86
Avoid calling Provider.forUseAtConfigurationTime() for Gradle >= 7.4
cefe1d6 
Gradle will start warning about the now-noop method in 8.x, for removal
in 9.0.

Fixes #29
@ejona86
Copy link
Collaborator

ejona86 commented Feb 9, 2023

This was fixed in 1.7.3. Now we'll need to upgrade the version used by protobuf-gradle-plugin and get a release out.

@ejona86 ejona86 mentioned this issue Feb 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ejona86 ejona86

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@eskatos @ejona86