Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qt] Give exact fix for OSV-2020-902 #7

Merged
merged 4 commits into from Aug 11, 2021

Conversation

rlohning
Copy link
Contributor

No description provided.

@rlohning
Copy link
Contributor Author

I don't know when this issue was introduced. I can reproduce it with Qt 5.12.1 and it may be older.

Is there something like "-type: FIX" for the added link?

Copy link
Collaborator

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@oliverchang oliverchang merged commit 9773afe into google:main Aug 11, 2021
@oliverchang
Copy link
Collaborator

oliverchang commented Aug 11, 2021

Is there something like "-type: FIX" for the added link?

Yes! The list is here: https://github.com/ossf/osv-schema/blob/main/schema.md#references-field (I edited your PR).

@rlohning rlohning deleted the improve_2020-902 branch August 12, 2021 10:28
@rlohning
Copy link
Contributor Author

Hi Oliver,

thank you for your improvements.

I see that the list of affected versions was already updated. I'm surprised though that "v5.15.2" is not in the list. I could reproduce the issue with that version and it's branch does not contain the fix. Did anything confuse the bot?

Cheers,
Robert

@oliverchang
Copy link
Collaborator

Thanks for pointing this out Robert! I've opened google/osv.dev#203 to investigate this.

@oliverchang
Copy link
Collaborator

This should be fixed by google/osv.dev#204. It'll likely get merged and deployed next week, and I'll rerun the analysis on all qt entries.

@rlohning
Copy link
Contributor Author

Thank you!

@rlohning
Copy link
Contributor Author

In case this is related, please have a look at #9 (comment)

@oliverchang
Copy link
Collaborator

fb452b4 now includes 5.15.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants