Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wireshark Build is Broken #1003

Closed
jonathanmetzman opened this issue Nov 20, 2017 · 2 comments
Closed

Wireshark Build is Broken #1003

jonathanmetzman opened this issue Nov 20, 2017 · 2 comments

Comments

@jonathanmetzman
Copy link
Contributor

Logs here:
https://oss-fuzz-build-logs.storage.googleapis.com/log-15db43c4-ed7e-40d8-8b78-7858257573bc.txt

These look like the relevant lines:

Step #3: + clang++ -O1 -fno-omit-frame-pointer -gline-tables-only -DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION -fsanitize=address -fsanitize-address-use-after-scope -fsanitize=fuzzer-no-link -stdlib=libc++ /work/fuzzshark_ip.o -o /workspace/out/address/fuzzshark_ip -lFuzzingEngine -L/work/install/lib -lwireshark -lwiretap -lwsutil -Wl,-Bstatic -lglib-2.0 -pthread -lpcre -lgcrypt -lgpg-error -lz -Wl,-Bdynamic
Step #3: /work/fuzzshark_ip.o: In function fuzz_init': Step #3: /src/wireshark/tools/oss-fuzzshark/fuzzshark.c:213: undefined reference to register_all_protocols'
Step #3: /src/wireshark/tools/oss-fuzzshark/fuzzshark.c:213: undefined reference to `register_all_protocol_handoffs'
Step #3: clang-6.0: error: linker command failed with exit code 1 (use -v to see invocation)
Finished Step #3
ERROR
ERROR: build step "gcr.io/oss-fuzz/wireshark" failed: exit status 1

@jonathanmetzman
Copy link
Contributor Author

@jwzawadzki can you please take a look?

ghost pushed a commit to wireshark/wireshark that referenced this issue Nov 21, 2017
…oved from -lepan

During compilation of oss-fuzzshark (google/oss-fuzz#1003):
Step #3: /src/wireshark/tools/oss-fuzzshark/fuzzshark.c:213: undefined reference to `register_all_protocols'
Step #3: /src/wireshark/tools/oss-fuzzshark/fuzzshark.c:213: undefined reference to `register_all_protocol_handoffs'

After cleanup of make-dissector-reg.py [b695b3e]
these functions are no longer part of epan library (I really wonder why...).
oss-fuzzshark need to compile and link register.c on their own.

Change-Id: I79adf5c1513a0934f140bbf501c181bf14d7619b
Reviewed-on: https://code.wireshark.org/review/24523
Petri-Dish: Jakub Zawadzki <darkjames-ws@darkjames.pl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Jakub Zawadzki <darkjames-ws@darkjames.pl>
@jwzawadzki
Copy link
Contributor

Should be fixed by https://code.wireshark.org/review/24523/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants